Fix read configuration#397
Open
chiarorosa wants to merge 3 commits into
Open
Conversation
- Dockerfile: Custom Overleaf image with Portuguese LaTeX support - .github/copilot-instructions.md: AI assistant instructions for the toolkit - config/overleaf.rc: Custom configuration for UFPEL edition
Replace the complex sed regex with a simpler approach using cut -d '=' -f2- to extract the value after the equals sign, followed by sed to remove quotes. This makes the function more readable and potentially more robust.
These files belong to the custom-ufpel-edition branch and should not be included in the PR for the read_configuration fix.
This was referenced Oct 22, 2025
Contributor
Member
|
So the effective change is removing the escaping from |
Contributor
No, it's removing |
Member
Which is effectively the same operation 😉 |
Contributor
|
Yeah, fair point. Would you mind stamping ✅ if you're also fine with it? |
das7pad
reviewed
May 20, 2026
Member
das7pad
left a comment
das7pad
left a comment
There was a problem hiding this comment.
LGTM, not tested.
There are unrelated changes in this PR. Do you mind force-pushing them away @chiarorosa ?
Also please fill out the CLA and tick the box on the PR. I've restored the section in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies read_configuration() in shared-functions.sh by replacing a complex sed regex with a clearer two-step parsing:
• Old: sed -r "s/^$name=(["']?)(.+)\1$/\2/"
• New: cut -d '=' -f2- | sed -r "s/^(["']?)(.+)\1$/\2/"
Why:
The new approach is easier to read and reason about while preserving behavior:
• Extracts the value after the first =
• Strips optional matching quotes around the value
Impact & Testing:
Related issues / Pull Requests
Contributor Agreement